packager lambda for QPE #4304
packager lambda for QPE #4304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4304 +/- ##
==========================================
- Coverage 39.09% 39.07% -0.03%
==========================================
Files 783 787 +4
Lines 34756 34813 +57
Branches 5522 5525 +3
==========================================
+ Hits 13589 13604 +15
- Misses 19985 20026 +41
- Partials 1182 1183 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The inference is reasonable. I naively assume _ always means "/". Could we use different chars ("-") for other invalid chars, or is that added complexity? |
|
@greptileai |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new package management functionality to the pkgpush Lambda function, focusing on automated package creation from S3 prefixes.
- Added
PackagerEventclass int4_lambda_pkgpush/__init__.pywith concerning use of global variables for boto sessions and multiple assertions instead of proper error handling - Added
rfc3986==2.0.0dependency for URI parsing in bothrequirements.txtandsetup.py - Modified
.github/workflows/deploy-lambdas.yamlto only deploy pkgpush Lambda, but deployment trigger configuration needs review - Added basic test coverage in
test_packager.pybut lacks error scenarios and edge cases - SQS handler explicitly refuses to process multiple records which may impact performance
5 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR updates the default package naming convention in the pkgpush Lambda function, changing from 'quilt-packager/pkg' to 'package/null' with corresponding test updates.
- Modified default package name constants in
/lambdas/pkgpush/tests/test_packager.pyto useDEFAULT_PKG_NAME_PREFIX = "package"andDEFAULT_PKG_NAME_SUFFIX = "null" - Added comprehensive test cases in
test_packager.pyto validate package name inference with the new defaults - Updated package name validation logic in
t4_lambda_pkgpush/__init__.pyto handle the new naming scheme - Added test coverage for edge cases like empty prefixes and special characters in package names
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Description
TODO